[Koha-patches] [PATCH] updateitem.pl cleanup

[Galen Charlton]

Hi,

On Wed, Jan 28, 2009 at 2:25 PM, Joe Atzberger
<joe.atzberger at liblime.com> wrote:
> updateitem.pl cleanup:
> ~ Comment out four unused dependencies!
> ~ Remove unused dbh.
> ~ Clarify defaults of "0" and add default of "" where needed for
> data integrity and to avoid warnings on undef comparisons.
> ~ Convert if/elsif's to series of if's.  The limitation that only
> one edit at a time would be performed comes from the *interface*, and
> is not a logical requirement.  The interface may be adapted. For example,
> changing "damaged" status and adding a note at the same time...
> something like "Missing first 12 pages."
> ~ Tidy up declarations.

I am rejecting this patch as is: the changes to updateitem.pl itself
are plausible, but the patch breaks functionality:

[1] Use this script to set an items lost, damaged, or withdrawn status.
[2] Go back to the item and set a note.
[3] Watch the lost, damaged, and withdrawn status get cleared - oops.

Please resubmit after either correcting the script to not update any
item fields that are not specified in the CGI parameters or adjusting
the template.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt