[Koha-patches] [PATCH] Prevent fines failure on NULL borrowernumber.

[paul POULAIN]

Joe Atzberger a écrit :
> Michael --
>
> Thanks for the reply.  I think NULL borrowernumber in issues is in 
> fact a mistake, broadly speaking.  You are correct that the design 
> currently allows it, but it also falls apart after it is allowed.  I 
> understand why we compromised at 3.0 release time, mainly to allow 
> offline circ (and legacy code, perhaps dealing w/ lost items?) to work 
> without failing, but I still regard it as inadvisable. 
My bet is :
* previously, we had only 1 issues table (instead of issues & old_issues)
* we need to be able to have borrowernumber=NULL for anonymisation 
(legal issues in many countries)
* when issues & old_issues were splitted, the borrowernumber=NULL became 
deprecated for issues (as a non returned item must not be 
borrowernumber=NULL), but no one noticed that

I agree that now, it is useless & integrity constraint can be increased 
on issues table (but not on old_issues)

cheers.

-- 
Paul POULAIN
http://www.biblibre.com
Expert en Logiciels Libres pour l'info-doc
Tel : (33) 4 91 81 35 08