[Koha-patches] [PATCH] [followup](bug #3370) fix the "Get" function name

[Joe Atzberger]

Wasn't there anywhere that used this function that needs to be updated
too?   I'm guessing there must be.  But if not, we should just delete it!

-- 
Joe Atzberger
LibLime - Open Source Library Solutions

On Tue, Jul 7, 2009 at 9:44 AM, Nahuel ANGELINETTI <
nahuel.angelinetti at biblibre.com> wrote:

> This fix the problem with the Get function in C4::Biblio, the new name is
> GetRecordValue and located in export_ok.
> ---
>  C4/Biblio.pm |   19 +++++++++++--------
>  1 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/C4/Biblio.pm b/C4/Biblio.pm
> index 262623e..c643e5b 100755
> --- a/C4/Biblio.pm
> +++ b/C4/Biblio.pm
> @@ -36,7 +36,7 @@ use C4::Charset;
>  require C4::Heading;
>  require C4::Serials;
>
> -use vars qw($VERSION @ISA @EXPORT);
> +use vars qw($VERSION @ISA @EXPORT @EXPORT_OK);
>
>  BEGIN {
>        $VERSION = 1.00;
> @@ -46,13 +46,16 @@ BEGIN {
>
>        # to add biblios
>  # EXPORTED FUNCTIONS.
> +    push @EXPORT_OK, qw(
> +        &GetRecordValue
> +    );
> +
>        push @EXPORT, qw(
>                &AddBiblio
>        );
>
>        # to get something
>        push @EXPORT, qw(
> -           &Get
>                &GetBiblio
>                &GetBiblioData
>                &GetBiblioItemData
> @@ -60,9 +63,9 @@ BEGIN {
>                &GetBiblioItemByBiblioNumber
>                &GetBiblioFromItemNumber
>
> -               GetFieldMapping
> -               SetFieldMapping
> -               DeleteFieldMapping
> +               &GetFieldMapping
> +               &SetFieldMapping
> +               &DeleteFieldMapping
>
>                &GetISBDView
>
> @@ -470,11 +473,11 @@ sub LinkBibHeadingsToAuthorities {
>     return $num_headings_changed;
>  }
>
> -=head2 Get
> +=head2 GetRecordValue
>
>  =over 4
>
> -my $values = Get($field, $record, $frameworkcode);
> +my $values = GetRecordValue($field, $record, $frameworkcode);
>
>  =back
>
> @@ -482,7 +485,7 @@ Get MARC fields from a keyword defined in fieldmapping
> table.
>
>  =cut
>
> -sub Get {
> +sub GetRecordValue {
>     my ($field, $record, $frameworkcode) = @_;
>     my $dbh = C4::Context->dbh;
>
> --
> 1.6.0.4
>  <http://lists.koha.org/mailman/listinfo/koha-patches>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20090708/19014272/attachment-0002.htm>