[Koha-patches] [PATCH] Bug 3399 : Checking in an item should remove LOST status.

Ryan Higgins rch at liblime.com
Mon Jul 13 21:56:51 CEST 2009


See bug 2750.
This patch calls ModDateLastSeen even if the checkin fails for
whatever reason.  This may not be the correct thing to do in
all cases, but it solves bug 3399.  Koha really needs a more
complete handling of lost statuses.
Also removes a redundant call to GetMemberDetails.
---
 C4/Circulation.pm |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index f620669..c8e2073 100644
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -1471,13 +1471,10 @@ sub AddReturn {
 		            #         	reload iteminformation holdingbranch with the userenv value
 		            $iteminformation->{'holdingbranch'} = C4::Context->userenv->{'branch'};
             }
-            ModDateLastSeen( $iteminformation->{'itemnumber'} );
             ModItem({ onloan => undef }, $biblio->{'biblionumber'}, $iteminformation->{'itemnumber'});
           
-		        if ($iteminformation->{borrowernumber}){
-			    ($borrower) = C4::Members::GetMemberDetails( $iteminformation->{borrowernumber}, 0 );
-            }
         }
+        ModDateLastSeen( $iteminformation->{'itemnumber'} );  # handles resetting lost status.
         # fix up the accounts.....
         if ( $iteminformation->{'itemlost'} ) {
             $messages->{'WasLost'} = 1;
-- 
1.5.6.2




More information about the Koha-patches mailing list