[Koha-patches] [PATCH 2/2] bug 3434 Fix SQL Syntax Error when setting claimdate

Colin Campbell colin.campbell at ptfs-europe.com
Wed Jul 22 16:42:57 CEST 2009


---
 C4/Serials.pm |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/C4/Serials.pm b/C4/Serials.pm
index 26b08db..478dd87 100644
--- a/C4/Serials.pm
+++ b/C4/Serials.pm
@@ -320,15 +320,14 @@ Update Claimdate for issues in @$serialids list with date $date
 
 sub UpdateClaimdateIssues {
     my ( $serialids, $date ) = @_;
+    if (!$date) {
+        $date = strftime('%Y-%m-%d',localtime);
+    }
     my $dbh   = C4::Context->dbh;
-    $date = strftime("%Y-%m-%d",localtime) unless ($date);
-    my $query = "
-        UPDATE serial SET claimdate=$date,status=7
-        WHERE  serialid in ".join (",",@$serialids);
-    ;
-    my $rq = $dbh->prepare($query);
-    $rq->execute;
-    return $rq->rows;
+    my $ids_str = join ',', @{$serialids};
+    my $query = 'UPDATE serial SET claimdate=? ,status=7 WHERE  serialid IN ( '
+     . $ids_str . ' )';
+    return $dbh->do($query,undef, $date);
 }
 
 =head2 GetSubscription
-- 
1.6.2.5




More information about the Koha-patches mailing list