[Koha-patches] [PATCH] New Messaging System.

Frédéric DEMIANS f.demians at tamil.fr
Sat Jul 25 13:26:48 CEST 2009


Very nice patch!

- kohaversion.pl containing 3.01.00.038 is not provided.

- For the new syspref, 'Allow any Library to delete any message' 
translation into French is: Permet à toute bibliothèque de supprimer les 
messages d'autres bibliothèques

> +sub GetMessages {
> + my ( $borrowernumber, $type, $branchcode ) = @_;
> +
> + if ( ! $type ) {
> + $type = '%';
> + }
> +
> + my $dbh = C4::Context->dbh;
> +
> + my $query = "SELECT
> + branches.branchname,
> + messages.*,
> + DATE_FORMAT( message_date, '%m/%d/%Y' ) AS message_date_formatted,

Date format doesn't follow 'dateformat' syspref.

On the Leave a message section, there is a Save message, but no Cancel 
button/link.

If you leave several messages to a borrower, you finish having Check out 
page with Checkouts and Holds tab pushed to the bottom of the page: see 
attached screenshot. In my opinion, messages should rather be displayed 
in a 3rd tab, next to Holds tab. (With the default, I agree, that 
message doesn't stand out anymore...) Another solution would be to place 
Messages section, at the right of Checking out section, into a fixed 
height div with vertical scrollbar.

Thanks.
-- 
Frédéric DEMIANS
http://www.tamil.fr/u/fdemians.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: borr-messages.png
Type: image/png
Size: 63428 bytes
Desc: not available
URL: </pipermail/koha-patches/attachments/20090725/be6628b9/attachment-0002.png>


More information about the Koha-patches mailing list