[Koha-patches] [PATCH] fix minor warning issues in SCO

Galen Charlton galen.charlton at liblime.com
Wed Jun 3 21:30:32 CEST 2009


* test for NO_MORE_RENEWALS now does expect
  that hash key will always exist
* removed unconditional warn
---
 opac/sco/sco-main.pl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl
index 984aded..9b15ac5 100755
--- a/opac/sco/sco-main.pl
+++ b/opac/sco/sco-main.pl
@@ -80,7 +80,7 @@ elsif ( $op eq "checkout" ) {
     if (scalar keys %$impossible) {
 
         #  warn "impossible: numkeys: " . scalar (keys(%$impossible));
-        warn join " ", keys %$impossible;
+        #warn join " ", keys %$impossible;
         my $issue_error = (keys %$impossible)[0];
 
         # FIXME  we assume only one error.
@@ -147,7 +147,7 @@ if ($borrower->{cardnumber}) {
     my ($issueslist) = GetPendingIssues( $borrower->{'borrowernumber'} );
     foreach my $it (@$issueslist) {
         my ($renewokay, $renewerror) = CanBookBeIssued($borrower, $it->{'barcode'},'','');
-        $it->{'norenew'} = 1 if $renewokay->{'NO_MORE_RENEWALS'} == 1;
+        $it->{'norenew'} = 1 if $renewokay->{'NO_MORE_RENEWALS'};
         push @issues, $it;
     }
 
-- 
1.5.6.5




More information about the Koha-patches mailing list