[Koha-patches] [PATCH] (bug #3306) fix circulation problems with ReturnBeforeExpiry and RenewalPeriodBase

[Galen Charlton]

Pardon me, I meant commit ea4247709028bd562ccf2bd4ce9a90c358368dc1. --gmc

On Mon, Jun 8, 2009 at 11:52 AM, Galen
Charlton<galen.charlton at liblime.com> wrote:
> Hi,
>
> I do not recommend that this patch be applied to origin/3.0.x;
> instead, commit a93a84749785cce6b7226181acac35799d3e70cf should be
> cherry-pick from origin/master to origin/3.0.x.  See below:
>
> On Mon, Jun 8, 2009 at 9:10 AM, Nahuel
> ANGELINETTI<nahuel.angelinetti at biblibre.com> wrote:
>>         #FIXME -- use circControl?
>> -        $datedue =  CalcDateDue($datedue,$loanlength,$branch); # this branch is the transactional branch.
>> +        $datedue =  CalcDateDue($datedue,$loanlength,$branch,$borrower);       # this branch is the transactional branch.
>
> The problem is that the conditional for the block this is contained in is:
>
> unless (@_ and $datedue = shift and $datedue->output('iso')) {
>
> However, $datedue was already extracted from @_.
>
> Regards,
>
> Galen
> --
> Galen Charlton
> VP, Research & Development, LibLime
> galen.charlton at liblime.com
> p: 1-888-564-2457 x709
> skype: gmcharlt
>



-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt