[Koha-patches] [PATCH] Bug 2889: Removed unused toggle variable from authtypes.pl

[Galen Charlton]

Hi Garry,

Thanks.  As Joe just did a more comprehensive cleanup patch for
authtypes.pl that includes removing the $toggle variable, I won't be
pushing this patch.  You lose the race this time ;)

By the way, I really appreciate your efforts working on code cleanup
bugs recently.

Regards,

Galen

On Tue, Jun 9, 2009 at 6:08 PM, Garry Collum<gcollum at gmail.com> wrote:
> Removed unused toggle variable from authtypes.pl and add template __odd__ logic for highlighting to authtypes.tmpl
> ---
>  admin/authtypes.pl                                 |    6 ------
>  .../prog/en/modules/admin/authtypes.tmpl           |    4 ++++
>  2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/admin/authtypes.pl b/admin/authtypes.pl
> index d360680..533d1eb 100755
> --- a/admin/authtypes.pl
> +++ b/admin/authtypes.pl
> @@ -143,15 +143,9 @@ if ($op eq 'add_form') {
>  ################## DEFAULT ##################################
>  } else { # DEFAULT
>     my ($count,$results)=StringSearch($searchfield,'web');
> -    my $toggle="white";
>     my @loop_data;
>     for (my $i=$offset; $i < ($offset+$pagesize<$count?$offset+$pagesize:$count); $i++){
>         my %row_data;
> -        if ($toggle eq 'white'){
> -            $row_data{toggle}="#ffffcc";
> -        } else {
> -            $row_data{toggle}="white";
> -        }
>         $row_data{authtypecode} = $results->[$i]{'authtypecode'};
>         $row_data{authtypetext} = $results->[$i]{'authtypetext'};
>         $row_data{auth_tag_to_report} = $results->[$i]{'auth_tag_to_report'};
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tmpl
> index 774d947..b9161e1 100644
> --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tmpl
> +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tmpl
> @@ -145,7 +145,11 @@ function Check(f) {
>        </tr>
>
>        <!-- TMPL_LOOP NAME="loop" -->
> +       <!-- TMPL_UNLESS NAME="__odd__" -->
> +               <tr class="highlight">
> +       <!-- TMPL_ELSE -->
>                <tr>
> +       <!-- /TMPL_UNLESS -->
>                        <td><!-- TMPL_VAR NAME="authtypecode" --></td>
>                        <td><!-- TMPL_VAR NAME="authtypetext" --></td>
>                        <td><!-- TMPL_VAR NAME="summary" --></td>
> --
> 1.5.6.5
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt