[Koha-patches] [PATCH] Remove unused variable and add FIXME.
Joe Atzberger
joe.atzberger at liblime.com
Sat Jun 20 02:32:43 CEST 2009
---
C4/Context.pm | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/C4/Context.pm b/C4/Context.pm
index 0d07ebf..4dab9a9 100644
--- a/C4/Context.pm
+++ b/C4/Context.pm
@@ -866,7 +866,6 @@ sub _new_stopwords
my $sth = $dbh->prepare("select word from stopwords");
$sth->execute;
while (my $stopword = $sth->fetchrow_array) {
- my $retval = {};
$stopwordlist->{$stopword} = uc($stopword);
}
$stopwordlist->{A} = "A" unless $stopwordlist;
@@ -957,7 +956,7 @@ sub get_shelves_userenv () {
=item _new_userenv
- C4::Context->_new_userenv($session);
+ C4::Context->_new_userenv($session); # FIXME: This calling style is wrong for what looks like an _internal function
Builds a hash for user environment variables.
@@ -971,7 +970,7 @@ _new_userenv is called in Auth.pm
#'
sub _new_userenv
{
- shift;
+ shift; # Useless except it compensates for bad calling style
my ($sessionID)= @_;
$context->{"activeuser"}=$sessionID;
}
--
1.5.6.5
More information about the Koha-patches
mailing list