[Koha-patches] [PATCH] Bad account expiration message when a user isn't, and no message when it is

Galen Charlton galen.charlton at liblime.com
Fri Mar 6 18:06:31 CET 2009


Hi,

On Fri, Mar 6, 2009 at 5:38 AM,  <henridamien.laurent at biblibre.com> wrote:

This patch has no functional effect.  Adding one more line of context shows why:

>    my $expiry = 0; # flag set if patron account has expired
>     if ($expiry_date and $expiry_date ne '0000-00-00' and
>             Date_to_Days(split /-/,$date) > Date_to_Days(split /-/,$expiry_date)) {
>                $messages = $expiry = 1;
> +    }else{
> +        $expiry = 0;
>     }
> -
> +

If $expiry is already initialized to 0, the else block has no effect.
Furthermore, I'm not able to reproduce the buggy behavior in HEAD.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt



More information about the Koha-patches mailing list