[Koha-patches] [PATCH] CORRECTION: fixes print statements with missing 'STDERR',

[Joe Atzberger]

On Sun, Mar 8, 2009 at 7:31 AM, Mason James <mason.loves.sushi at gmail.com>wrote:

> err, the 'warn sprintf()'s still actually output to STDOUT :/
> this patch fixes that.
>

Um, no they don't.  "$debug and printf ..." would go to STDOUT, but warns
would still go to STDERR.  To demonstrate:

perl -e 'warn sprintf "foo"' >/dev/null

The lines you changed to warns probably should also have the trailing "\n"
removed since warn takes care of that itself.  I think I agree with the
intention of the patch, but the description and execution have issues.

--joe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20090309/8283086f/attachment-0002.htm>