[Koha-patches] [PATCH] fixes print statements with missing 'STDERR', causing 500 errors when debugging

[Galen Charlton]

Hi,

On Sun, Mar 8, 2009 at 6:58 AM, Mason James <mason.loves.sushi at gmail.com> wrote:
>  sub ldapserver_error ($) {
> -       return sprintf('No ldapserver "%s" defined in KOHA_CONF: ' . $ENV{KOHA_CONF}, shift);
> +       return warn sprintf('No ldapserver "%s" defined in KOHA_CONF: ' . $ENV{KOHA_CONF}, shift);
>  }

Changing "return sprintf" to "return warn sprintf" means that you're
changing the return value from the error message to the value 1.  The
die statements that use ldapserver_error() would thus provide *less*
information.

I agree with the intention of making sure that debug messages get sent
to STDERR instead of STDOUT, but this patch and its successor need
work.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt