[Koha-patches] [PATCH] add the possibility to replace, in sysprefs, the code by it's valuecode with {{code}} ex : {{995c}}

Nahuel ANGELINETTI nahuel.angelinetti at biblibre.com
Mon Mar 23 17:30:24 CET 2009


Hi,

Le Fri, 6 Mar 2009 12:41:39 -0500,
Galen Charlton <galen.charlton at liblime.com> a écrit :

> Hi,
> 
> On Fri, Mar 6, 2009 at 5:37 AM,  <henridamien.laurent at biblibre.com>
> wrote:
> > From: Nahuel Angelinetti <nahuel.angelinetti at biblibre.com>
> >
> > Signed-off-by: Henri-Damien LAURENT
> > <henridamien.laurent at biblibre.com>
> 
> The concerns I raised when I reject this patch in October still have
> not been addressed.  From my email of 10/23/2008:
> 
> "1. The patch description needs improvement - it doesn't identify
> which syspref it's talking about, it doesn't make it clear that it's
> talking about the ISBD display, and there really ought to be an
> example of what the patch is trying to accomplish.
> 
> 2. This patch changes opac-ISBDdetail.pl, but doesn't change
> catalogue/ISBDdetail.pl, even though the ISBD display logic is
> virtually identical.
> 
> 3. In fact, the logic that generates the ISBD display really ought to
> be factored into a common routine that's referred to by both the staff
> and OPAC scripts."

I just resent 2 patchs that extract the ISBD view generation to a
C4::Biblio function. And which implements the needed functionnality.

bests,

-- 
Nahuel ANGELINETTI




More information about the Koha-patches mailing list