[Koha-patches] [PATCH] Finishing off StripWhiteSpace tool, you can now switch this on (off by default) to remove whitespace from the outputted html

[Chris Cormack]

On Wed, Apr 1, 2009 at 7:58 AM, Joe Atzberger <joe.atzberger at liblime.com> wrote:
> This all seems like a bad way to implement whatever bandwidth and
> client-side storage savings you will get from whitespace-stripping.  Koha
> really shouldn't be in the business of trying to reinvent mod_deflate, gzip
> compression or minify.  Notably, those guys all:
>
> take affect outside the application, and therefore
> don't involve a regular expression being compiled and parsing through the
> entirety of script output every page load, and
> they do a cleaner job of what FilterWhiteSpace is trying to do,
> with better performance,
> and bring their considerably higher-order features as well.
> Oh, and no extra syspref.
>
> I understand the motivation for minifying Koha output, and I agree with that
> idea rather strongly, but I think we should be using existing tools and
> Apache features unless they prove unsatisfactory.
>
The no extra syspref was desired,
The discussion took place on irc, and the syspref was decided upon so
it could easily be toggled on and off.
There is no reason you cant do both, and with the syspref set to off
no one would notice.
mod_gzip has issues with certain browsers, mod_deflate is apache specific ...

Having said that, I have no issues if this patch is rejected, it was
discused on IRC, galen asked for a patch, and I sent it :)

Chris