[Koha-patches] [PATCH] [HEAD] (bug #3170) check if mandatory fields are not empty

Galen Charlton galen.charlton at liblime.com
Mon May 11 17:08:24 CEST 2009


Hi Nahuel,

On Thu, Apr 30, 2009 at 9:09 AM, Nahuel ANGELINETTI
<nahuel.angelinetti at biblibre.com> wrote:
> This patch make authority and biblio add/edit to check that at least one subfield of mandatory fields are filled-in.

I discovered the following problems during testing - please work on
this and resubmit:

[1] The patch had no discernible effect on editing bib records.  When
I marked a field as required (but none of its subfields), the editor
would still let me save a bib record even if I hadn't entered any data
into any of the tag's subfields.

[2] When editing authority records, the patch *did* catch when a
mandatory field had no content in any of its subfields.  However, it
goes too far - for mandatory variable control fields (tags < 010) that
do not have subfields, it prevents you from saving a record because it
can't find any subfields for them, even though those fields by
definition don't have subfields.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt



More information about the Koha-patches mailing list