[Koha-patches] [PATCH] Fixing more warnings

[Galen Charlton]

Hi Chris,

On Tue, May 12, 2009 at 3:30 AM, Chris Cormack <chris at bigballofwax.co.nz> wrote:
> -my $content_type = ($cgi->param('format') && $cgi->param('format') =~ /rss|atom/) ? "application/xml" :
> -                   "text/html";
> -
> +my $content_type;
> +if ($cgi->param('format') && $cgi->param('format') =~ /rss|atom/ ){
> +    $content_type = "application/xml";
> +}
> +else {
> +    $content_type = "text/html";
> +}

I'll be pushing this patch, but what's wrong with my $foo = $condition
? $valuea : $valueb; ?  That's a perfectly legitimate construct.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt