[Koha-patches] [PATCH] [HEAD] (bug #3170) check if mandatory fields are not empty

[Galen Charlton]

Hi,

On Tue, May 12, 2009 at 6:26 AM, Nahuel ANGELINETTI
<nahuel.angelinetti at biblibre.com> wrote:
> This is very strange, because I have not this issue. If I have only
> one field which is mandatory, without any mandatory subfield, and no
> data, the editor don't let me save the record. So I don't know what's
> happening.

Are there any dependent patches that you may have not sent yet?

>> [2] When editing authority records, the patch *did* catch when a
>> mandatory field had no content in any of its subfields.  However, it
>> goes too far - for mandatory variable control fields (tags < 010) that
>> do not have subfields, it prevents you from saving a record because it
>> can't find any subfields for them, even though those fields by
>> definition don't have subfields.
>
> So, why are they mandatory?

It's OK for them to be mandatory, but your patch is not testing them
correctly.  The point of a variable control field AKA fixed field is
that it does not have subfields, so testing a fixed field looking for
subfield divs is kind of pointless.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt