[Koha-patches] [PATCH] KOHA BUG 1277 Enhance: Z39.50 More search criteria

Galen Charlton galen.charlton at liblime.com
Wed May 13 15:35:23 CEST 2009


Hi Darrell,

This patch doesn't apply against HEAD - please check, rebase if
necessary, and resubmit.  I've inserted a few more comments below.

On Tue, May 12, 2009 at 4:55 PM,  <darrellulm at kohavmware> wrote:
> From: root <root at smfpl.org>

Please use git config --global user.name "Darrelll Ulm" to set the
user name, and consider using git config --global user.email unless
you actually read email sent to root at smfpl.org.

>        if ($lccn) {
> -        $query .= " \@attr 1=9 $lccn ";
> +        $query .= " \@attr 1=51 $lccn ";
>         $nterms++;
>     }

Are you sure about this?  1=9 is the standard Bib-1 attribute for the
LCCN (card number, not call number).  1=51 is the Bib-1 attribute for
'No. music publisher', which doesn't seem relevant for an LCCN search.

Regards,

Galen
-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt



More information about the Koha-patches mailing list