[Koha-patches] [PATCH] [3.0] patch fixes impossible 'to_address' in overdues.pl

[Ryan Higgins]

Applicable, though perhaps superfluous; at least according to
original design, I understood to_address to be intended as a
means of overriding a recipient's preferred address.
There's some messiness here, since we have C4::Letters::EnqueueLetter
doing pretty much the same job as C4::Messages::enqueue
C4::Letters::EnqueueLetter should be deprecated in favor of C4::Messages
to allow the latter to determine patron preferences.
Point being, no real reason to add another point in the code that will
have to be changed later when the patron messaging preferences
are more fully implemented.  overdue_notices.pl should leave the job
of picking the right address to the messaging module unless it has a
real reason not to.


Ryan


On Thu, May 21, 2009 at 5:48 PM, Mason James
<mason.loves.sushi at gmail.com> wrote:
>
> On 2009/05/22, at 1:45 AM, Galen Charlton wrote:
>
>> Hi Mason,
>>
>> At first glance it appears that this patch would also be applicable to
>> head.  Do you know if the problem is specific only to 3.0.x?
>>
>> Regards,
>>
>> Galen
>
>
> Heya Galen,
>
> I just checked quickly, looks like this patch is applicable to HEAD too
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Ryan Higgins

LibLime  *  Open-Source Solutions for Libraries
Featuring KohaZOOM ILS
888-564-2457  x704