[Koha-patches] [PATCH] Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor.

[Galen Charlton]

Hi Garry,

This patch needs some work.  When I tested it, after you clone a
repeatable field such as the 022, if you click to expand the copy you
made, the *original* tag gets expanded.  One way to resolve that is to
adjust CloneField() so that it catches the new ExpandField() call that
your patch adds and changes the ID to the ID of the new tag.

Regards,

Galen

On Fri, May 22, 2009 at 8:38 PM, Garry Collum <gcollum at gmail.com> wrote:
> Changed the tagnum <span> into an anchor and added javascript to expand the marc fields if the number is clicked.  This only worked properly when the html tag was an anchor.
> The tagnum property in the css file that was changed is only used in addbiblio.tmpl, eventhough additem.tmpl and authorities.tmpl also use this css file.
> ---
>  koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css  |    5 +++--
>  .../prog/en/modules/cataloguing/addbiblio.tmpl     |    2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css
> index 6e0a58c..c4a1ac5 100644
> --- a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css
> +++ b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css
> @@ -69,11 +69,12 @@ div.subfield_line label {
>        padding : .2em 0;
>  }
>
> -.tagnum {
> +a.tagnum {
>        font-size : 110%;
>        font-weight : bold;
>        color : #000;
>        padding : .1em .3em .1em 0;
> +       text-decoration : none;
>  }
>
>  .subfield {
> @@ -115,4 +116,4 @@ div.subfield_line label {
>  }
>  #cataloguing_additem_newitem .input_marceditor {
>        width : auto;
> -}
> \ No newline at end of file
> +}
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl
> index 0a3c92f..c383a06 100644
> --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl
> +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl
> @@ -642,7 +642,7 @@ function unHideSubfield(index,labelindex) { // FIXME :: is it used ?
>        <div class="tag" id="tag_<!-- TMPL_VAR name="tag"-->_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->">
>         <div class="tag_title" id="div_indicator_tag_<!-- TMPL_VAR name="tag"-->_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->">
>             <!-- TMPL_UNLESS name="hide_marc" -->
> -                <span class="tagnum" title="<!-- TMPL_VAR NAME="tag_lib" -->"><!-- TMPL_VAR NAME="tag" --></span>
> +                <a href="#" tabindex="1" class="tagnum" title="<!-- TMPL_VAR NAME="tag_lib" -->" onclick="ExpandField('tag_<!-- TMPL_VAR name="tag"-->_<!-- TMPL_VAR NAME='index' --><!-- TMPL_VAR NAME="random" -->'); return false;"><!-- TMPL_VAR NAME="tag" --></a>
>                 <!-- TMPL_IF NAME="fixedfield" -->
>                        <input tabindex="1" class="indicator flat" type="text" style="display:none;" name="tag_<!-- TMPL_VAR NAME="tag" -->_indicator1_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->" size="1" maxlength="1" value="<!-- TMPL_VAR NAME="indicator1" -->" />
>                        <input tabindex="1" class="indicator flat" type="text" style="display:none;" name="tag_<!-- TMPL_VAR NAME="tag" -->_indicator2_<!-- TMPL_VAR NAME='index'--><!-- TMPL_VAR name="random" -->" size="1" maxlength="1" value="<!-- TMPL_VAR NAME="indicator2" -->" />
> --
> 1.5.6.5
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Galen Charlton
VP, Research & Development, LibLime
galen.charlton at liblime.com
p: 1-888-564-2457 x709
skype: gmcharlt