[Koha-patches] [PATCH 69/78] Suggestions.pm, probably useless & not working (check with hdl)
Michael Hafen
mdhafen at tech.washk12.org
Thu May 28 20:09:27 CEST 2009
This breaks SearchSuggestion(), just so you know.
Any array or hash in a list assignment will take all elements from the
list on the right of the '='. So the code below pushes all parameters
into the %suggestion hash, as key / value pairs, and $suggestedbyme
doesn't get set.
On Thu, 2009-05-28 at 18:33 +0200, paul.poulain at biblibre.com wrote:
> From: Paul Poulain <paul.poulain at biblibre.com>
>
> ---
> C4/Suggestions.pm | 187 ++++++++++++++++++++++++++---------------------------
> 1 files changed, 91 insertions(+), 96 deletions(-)
>
> diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm
> index 1732540..8d9295b 100644
> --- a/C4/Suggestions.pm
> +++ b/C4/Suggestions.pm
[snip]
> @@ -85,7 +85,7 @@ Note the status is stored twice :
> =cut
>
> sub SearchSuggestion {
> - my ($user,$author,$title,$publishercode,$status,$suggestedbyme,$branchcode)=@_;
> + my (%suggestion,$suggestedbyme)=@_;
> my $dbh = C4::Context->dbh;
> my $query = "
> SELECT suggestions.*,
[snip]
--
Michael Hafen
Systems Analyst and Programmer
Washington County School District
Utah, USA
for Koha checkout
http://development.washk12.org/gitweb/
or
git://development.washk12.org/koha
More information about the Koha-patches
mailing list