[PATCH] C4/Biblio.pm: bugfix in GetISBDView

Sébastien Hinderer Sebastien.Hinderer at ens-lyon.org
Wed Nov 4 08:57:25 CET 2009


There was a comment in the middle of the substitution of
{{subfieldtag}} by its value, and that comment spoiled the substitution.
The comment has been removed rather than moved because it does not
seem that necessary: compared to the sur-rounding code, this
line is rather readable and does probably not diserve a comment.
---
 C4/Biblio.pm |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index cf48c91..fc5031b 100644
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -727,11 +727,7 @@ sub GetISBDView {
                   $subf[$i][1], '', $tagslib );
                 my $tagsubf = $tag . $subfieldcode;
     
-                $calculated =~ s/                  # replace all {{}} codes by the value code.
-                                  \{\{$tagsubf\}\} # catch the {{actualcode}}
-                                /
-                                  $valuecode     # replace by the value code
-                               /gx;
+                $calculated =~ s/\{\{$tagsubf\}\}/$valuecode/gx;
     
                 $calculated =~
             s/\{(.?.?.?.?)$tagsubf(.*?)\}/$1$subfieldvalue$2\{$1$tagsubf$2\}/g;
-- 
1.6.5


--/04w6evG8XlLl3ft--


More information about the Koha-patches mailing list