[Koha-patches] [PATCH] (bug #3760) fix and improve some reports

Nahuel ANGELINETTI nahuel.angelinetti at biblibre.com
Wed Nov 4 16:43:56 CET 2009


Done in followup

Le Wed, 4 Nov 2009 08:40:16 -0700,
Mike Hafen <mdhafen at tech.washk12.org> a écrit :

> Looks good.  I see a couple of warn's though.
> 
> On Wed, Nov 4, 2009 at 8:02 AM, Nahuel ANGELINETTI <
> nahuel.angelinetti at biblibre.com> wrote:
> 
> > This patch fix some problems with dates, and itemtypes level.
> > And it improve some sql queries.
> > ---
> >  reports/borrowers_out.pl  |   26 +++++++-------------------
> >  reports/cat_issues_top.pl |   38
> > +++++++++++++++++--------------------- 2 files changed, 24
> > insertions(+), 40 deletions(-)
> >
> > diff --git a/reports/borrowers_out.pl b/reports/borrowers_out.pl
> > index ff5e782..3f91635 100755
> > --- a/reports/borrowers_out.pl
> > +++ b/reports/borrowers_out.pl
> >
> [snip]
> 
> > @@ -197,7 +198,7 @@ sub calculate {
> >
> >         my $sth2 = $dbh->prepare( $strsth2 );
> >         $sth2->execute;
> > -
> > +        warn $strsth2;
> >         while (my ($celvalue) = $sth2->fetchrow) {
> >             my %cell;
> >     #          my %ft;
> >
> [snip]
> 
> > @@ -263,7 +251,7 @@ sub calculate {
> >         } else { $max=$line;}
> >         $strcalc .= " LIMIT 0,$max";
> >      }
> > -#    warn "SQL :". $strcalc;
> > +    warn "SQL : ". $strcalc;
> >
> >     my $dbcalc = $dbh->prepare($strcalc);
> >     $dbcalc->execute;
> > --
> > 1.6.3.3
> >
> > _______________________________________________
> > Koha-patches mailing list
> > Koha-patches at lists.koha.org
> > http://lists.koha.org/mailman/listinfo/koha-patches
> >


-- 
Nahuel ANGELINETTI




More information about the Koha-patches mailing list