[Koha-patches] [PATCH] Bug 3774: Accounts::chargelostitem uses title, but title not available to it (revised patch)

[Bavousett, David]

...and this is actually for bug 3775--I'm having a rough day, sorta.
Galen, can you fix, or should I resubmit?

--JDB

-----Original Message-----
From: J. David Bavousett [mailto:dbavousett at ptfs.com] 
Sent: Friday, November 06, 2009 11:00 AM
To: patches at koha.org
Cc: Bavousett, David
Subject: [PATCH] Bug 3774: Accounts::chargelostitem uses title, but
title not available to it (revised patch)

This patch fixes the SELECT so that title is available when it is used
later on, which will prevent 'Use of uninitialized value' errors.

It also uses JOIN properly, which the original query and my initial
patch for this
did not.
---
 C4/Accounts.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/C4/Accounts.pm b/C4/Accounts.pm
index e137587..c82440c 100644
--- a/C4/Accounts.pm
+++ b/C4/Accounts.pm
@@ -283,7 +283,7 @@ sub chargelostitem{
    
     my $dbh = C4::Context->dbh();
     my ($itemnumber) = @_;
-    my $sth=$dbh->prepare("SELECT * FROM issues, items WHERE
issues.itemnumber=items.itemnumber and  issues.itemnumber=?");
+    my $sth=$dbh->prepare("SELECT issues.*, items.*, biblio.title FROM
issues JOIN items USING itemnumber JOIN biblio USING(biblionumber) WHERE
issues.itemnumber=?");
     $sth->execute($itemnumber);
     my $issues=$sth->fetchrow_hashref();
 
-- 
1.5.6.5