[Koha-patches] [PATCH] Bug 2505: Enabled warnings in boraccount.pl and pay.pl.

Garry Collum gcollum at gmail.com
Fri Sep 4 18:01:45 CEST 2009


Enabled warnings in members/boraccount.pl and members/pay.pl.  Fixed resulting warnings.
---
 members/boraccount.pl |    6 +++++-
 members/pay.pl        |    4 +++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/members/boraccount.pl b/members/boraccount.pl
index cfe40c1..9417ab9 100755
--- a/members/boraccount.pl
+++ b/members/boraccount.pl
@@ -23,6 +23,8 @@
 # Suite 330, Boston, MA  02111-1307 USA
 
 use strict;
+use warnings;
+
 use C4::Auth;
 use C4::Output;
 use C4::Dates qw/format_date/;
@@ -44,10 +46,12 @@ my ($template, $loggedinuser, $cookie)
                             });
 
 my $borrowernumber=$input->param('borrowernumber');
+my $action = $input->param('action') || '';
+
 #get borrower details
 my $data=GetMember($borrowernumber,'borrowernumber');
 
-if ( $input->param('action') eq 'reverse' ) {
+if ( $action eq 'reverse' ) {
   ReversePayment( $borrowernumber, $input->param('accountno') );
 }
 
diff --git a/members/pay.pl b/members/pay.pl
index f19f5b8..02bb683 100755
--- a/members/pay.pl
+++ b/members/pay.pl
@@ -26,6 +26,8 @@
 =cut
 
 use strict;
+use warnings;
+
 use C4::Context;
 use C4::Auth;
 use C4::Output;
@@ -82,7 +84,7 @@ for ( my $i = 0 ; $i < @names ; $i++ ) {
         $check = 2;
     }
 }
-my $total = $input->param('total');
+my $total = $input->param('total') || '';
 if ( $check == 0 ) {
     if ( $total ne '' ) {
         recordpayment( $borrowernumber, $total );
-- 
1.5.6.5




More information about the Koha-patches mailing list