[Koha-patches] [PATCH] Bug 4307: Fixes branch order in inventory form.

[Galen Charlton]

Hi Garry,

On Sat, Mar 20, 2010 at 10:02 AM, Garry Collum <gcollum at gmail.com> wrote:
> + at branch_loop = sort {$a->{branchname} cmp $b->{branchname}} @branch_loop;
> +unshift @branch_loop, {value => "", branchname => "All Locations", };
> +

This approach for sorting the branch names is OK, but the handling of
the 'all locations' option is not - it introduces text that the
translation system can't get at.  Whenever a default option is needed
for a drop-down list, the default should be specified in the template,
not the code.

Regards,

Galen
-- 
Galen Charlton
gmcharlt at gmail.com