[Koha-patches] [PATCH 17/55] Minor bug fix rebuild_zebra

[Galen Charlton]

Hi,

On Wed, Mar 10, 2010 at 4:25 PM, Henri-Damien LAURENT
<henridamien.laurent at biblibre.com> wrote:
> From: Paul Poulain <paul.poulain at biblibre.com>
>
> removing only is2709 for authorities

Do you have evidence that the issue behind why that restriction exists
in the first place has been resolved?  See commit
57d128f72781fc854936ab0c4e8dffde167108bc.

> +    if ($marc->fields()){
> +        return $marc;
> +    } else {
> +        return undef;
> +    }
>  }

This is  superfluous - by the time it gets to this point, it will
contain a valid MARC::Record object.  If somehow it is retrieving a
MARC record that has no fields defined, that indicates a data problem
that needs to be dealt with lower down in the stack.

Regards,

Galen
-- 
Galen Charlton
gmcharlt at gmail.com