[Koha-patches] [PATCH] bugfix returns - date returned is one day in the past

[Ian Walls]

Just to put a number on it, this is bug 4326.

On Mon, Apr 19, 2010 at 6:32 PM, Michael Hafen <mdhafen at tech.washk12.org>wrote:

> Don't pass a Dropbox Branch to MarkIssueReturned if we aren't in dropbox
> mode.
> ---
>  C4/Circulation.pm |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/C4/Circulation.pm b/C4/Circulation.pm
> index d780189..dc44f52 100644
> --- a/C4/Circulation.pm
> +++ b/C4/Circulation.pm
> @@ -1476,14 +1476,16 @@ sub AddReturn {
>     # case of a return of document (deal with issues and holdingbranch)
>     if ($doreturn) {
>         $borrower or warn "AddReturn without current borrower";
> -               my $circControlBranch =
> _GetCircControlBranch($item,$borrower);
> +               my $dropbox_Branch =
> _GetCircControlBranch($item,$borrower);
>         if ($dropbox) {
>             # don't allow dropbox mode to create an invalid entry in issues
> (issuedate > returndate) FIXME: actually checks eq, not gt
>             undef($dropbox) if ( $item->{'issuedate'} eq
> C4::Dates->today('iso') );
> +        } else {
> +            undef($dropbox_Branch);  # Dont need this set
>         }
>
>         if ($borrowernumber) {
> -            MarkIssueReturned($borrowernumber, $item->{'itemnumber'},
> $circControlBranch);
> +            MarkIssueReturned($borrowernumber, $item->{'itemnumber'},
> $dropbox_Branch);
>             $messages->{'WasReturned'} = 1;    # FIXME is the "= 1" right?
>  This could be the borrower hash.
>         }
>
> --
> 1.6.3.3
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Ian Walls
Lead Development Specialist
ByWater Solutions
ALA Booth # 817
Phone # (888) 900-8944
http://bywatersolutions.com
ian.walls at bywatersolutions.com
Twitter: @sekjal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20100420/cbff0895/attachment-0002.htm>