[Koha-patches] [PATCH] Bug 4394 Allow opaccolorstylesheet syspref to use an external URL

[LAURENT Henri-Damien]

Le 21/04/2010 14:41, Jane Wagner a écrit :
> Previous code would only allow for an auxiliary stylesheet on the same server
> ---
>  .../opac-tmpl/prog/en/includes/doc-head-close.inc  |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc b/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc
> index a94acd2..ab30a1c 100644
> --- a/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc
> +++ b/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc
> @@ -5,7 +5,7 @@
>  <!-- TMPL_IF name="opacstylesheet" --><link rel="stylesheet" type="text/css" href="<!-- TMPL_VAR NAME="opacstylesheet" -->" /><!-- TMPL_ELSE -->
>  <!-- TMPL_IF name="opaclayoutstylesheet" --><link rel="stylesheet" type="text/css" href="<!-- TMPL_VAR NAME="themelang" -->/css/<!-- TMPL_VAR NAME="opaclayoutstylesheet" -->" /><!-- TMPL_ELSE --><link rel="stylesheet" type="text/css" href="<!-- TMPL_VAR NAME="themelang" -->/css/opac.css" /><!-- /TMPL_IF --><!-- /TMPL_IF -->
>  <!-- TMPL_IF name="opaccolorstylesheet" -->
> -    <link rel="stylesheet" type="text/css" href="<!-- TMPL_VAR NAME="themelang" -->/css/<!-- TMPL_VAR NAME="opaccolorstylesheet" -->" />
> +    <link rel="stylesheet" type="text/css" href="<!-- TMPL_VAR NAME="opaccolorstylesheet" -->" />
>  <!-- /TMPL_IF -->
>  <!-- TMPL_IF name="opac_css_override" -->
>      <link rel="stylesheet" type="text/css" href="<!-- TMPL_VAR NAME="themelang" -->/css/<!-- TMPL_VAR NAME="opac_css_override" -->" />
suggestion :
I think that this change could break defined opaccolorstylesheet already
used. Could it be improved so that if opaccolorstylesheet would not
begin with http:// themelang/css would be automatically added to that name ?

My 2 cents.
-- 
Henri-Damien LAURENT