[Koha-patches] small check in fix

Galen Charlton gmcharlt at gmail.com
Fri Apr 30 15:12:31 CEST 2010


Hi Chad,

Thank you for your patch. As it happens, somebody else scooped you, so
this will be fixed in the upcoming version of Koha, 3.2.  However, I
encourage you to keep submitting patches as you find bugs to fix.

Regards,

Galen

On Wed, Apr 28, 2010 at 4:26 PM, Chad Billman <chad at pennmanor.net> wrote:
> One of our librarians noticed the check in date is always showing up as the previous day even if dropbox mode is not enabled. The following patch seems to fix the issue on our system (3.0.5). Let me know if this patch needs to be in another format.
>
> Thanks,
> Chad Billman
>
> ---
>  C4/Circulation.pm |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/C4/Circulation.pm b/C4/Circulation.pm
> index 81cc08b..50afd5e 100644
> --- a/C4/Circulation.pm
> +++ b/C4/Circulation.pm
> @@ -1366,7 +1366,7 @@ sub AddReturn {
>                                # don't allow dropbox mode to create an invalid entry in issues (issuedate > returndate) FIXME: actually checks eq, not gt
>                                undef($dropbox) if ( $iteminformation->{'issuedate'} eq C4::Dates->today('iso') );
>                        }
> -            MarkIssueReturned($borrower->{'borrowernumber'}, $iteminformation->{'itemnumber'},$circControlBranch);
> +            MarkIssueReturned($borrower->{'borrowernumber'}, $iteminformation->{'itemnumber'}, $dropbox? $circControlBranch: undef);
>             $messages->{'WasReturned'} = 1;    # FIXME is the "= 1" right?
>             # continue to deal with returns cases, but not only if we have an issue
>
> --
> 1.6.5.2
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Galen Charlton
gmcharlt at gmail.com



More information about the Koha-patches mailing list