[Koha-patches] [PATCH] (bug #5154) fix most checkouts report

Nahuel ANGELINETTI nahuel.angelinetti at biblibre.com
Thu Aug 19 15:48:21 CEST 2010


don't take care of null values
---
 reports/bor_issues_top.pl |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl
index bb17d0a..eff3d1d 100755
--- a/reports/bor_issues_top.pl
+++ b/reports/bor_issues_top.pl
@@ -296,10 +296,11 @@ sub calculate {
     $strcalc .= "SELECT  CONCAT(borrowers.surname , \",\\t\",borrowers.firstname),  COUNT(*) AS RANK, borrowers.borrowernumber AS ID";
     $strcalc .= " , $colfield " if ($colfield);
     $strcalc .= " FROM `old_issues`
-                  LEFT JOIN  borrowers  ON old_issues.borrowernumber=borrowers.borrowernumber
-                  LEFT JOIN    items    ON items.itemnumber=old_issues.itemnumber
-                  LEFT JOIN biblioitems ON (biblioitems.biblioitemnumber=items.biblioitemnumber)
-                  WHERE 1";
+                  LEFT JOIN  borrowers  USING(borrowernumber)
+                  LEFT JOIN    items    USING(itemnumber)
+                  LEFT JOIN biblioitems USING(biblioitemnumber)
+                  WHERE old_issues.borrowernumber IS NOT NULL
+                  ";
 	my @filterterms = (
 		'old_issues.timestamp  >',
 		'old_issues.timestamp  <',
-- 
1.7.0.4



More information about the Koha-patches mailing list