[Koha-patches] [PATCH] [Bug 5465] Makefile.PL asks for too high version of Business::ISBN

[Liz Rea]

I did actually think about this before I did it. :)

I asked around if it would be better to update the documentation to take the
package out of the install script and add it to the CPAN list, or do what I
did, and the general consensus was that backing down the required version
was a better option (since the newer version doesn't add any functionality
that we actually use), so I did that.

The reason is that a lot of people use Lenny (and or Ubuntu, which would
cause this same issue), and Squeeze/Sid aren't stable yet (even though they
work fine, I know that). Every indication I've gotten is that "we" prefer
packaged versions of things instead of pulling direct from CPAN. I chose to
eliminate the error message when installing on Lenny/Ubuntu from
Makefile.PL, and allow a required version that was lower than the current
version to help eliminate a bad user experience (An error!!! OMG! What do I
do!).

I truly don't care which way it's done: we can remove it from the package
script and add it to the modules requiring installation through CPAN, no
problem. I'll do those patches too, if necessary.

That said, I don't think the reasoning behind this particular patch is
unsound, based on past precedent.

Liz Rea
NEKLS

On Thu, Dec 2, 2010 at 9:39 AM, Chris Nighswonger <
cnighswonger at foundations.edu> wrote:

> On Thu, Dec 2, 2010 at 9:48 AM, Liz Rea <lrea at nekls.org> wrote:
>
>> Backing down the version to 2.0301 to match the Lenny available package.
>>
>
> Hmm... 2.05 is the newest version of this module in cpan. I think
> Makefile.PL should always ask for what is truly the newest version rather
> than being tied to a particular distribution.
>
> my $0.02 worth
>
> Kind Regards,
> Chris
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20101202/a9695b3c/attachment.htm>