[Koha-patches] [PATCH] Bug 5418: Rev-4 patch new itemBarcodeInputFilter for libsuite8 style barcodes

[Frédéric DEMIANS]

> This revision adds conversion support for some libsuite8 barcodes
> which are only numbers. i.e. these barcodes dont start with item type.
> e.g. 0002245 or 472. In libsuite8 such barcodes are assumed to be of
> type book with associated item type code 'b'. Tests for same have also
> been added to t/Circulation_barcodedecode.t

The patch works as expected. Since it's driven by a syspref, Koha
barcodes operation isn't affected by this patch as long as the syspref
isn't set to the appropriate value.

But:

Your patch modify installer/data/mysql/updatedatabase.pl. It souldn't.
You're modifying an old DB update which will never been called again on
new installation.

You also modify itemBarcodeInputFilter syspref in
data/mysql/en/mandatory/sysprefs.sql. I'm not sure it's required
anymore. You add your new syspref in circulation.pref. It's enough.
Others can correct me if I'm wrong.

--
Frédéric