[Koha-patches] [PATCH 2/2] Bug 5106 Followup

[LAURENT Henri-Damien]

Le 08/12/2010 12:47, Frédéric DEMIANS a écrit :
> LAURENT Henri-Damien :
> 
>>>      my $results = $stylesheet->transform($source);
>>>      my $newxmlrecord = $stylesheet->output_string($results);
>> In my experience, unconditional utf8::decode can be harmful.
>> Would you mind using : C4::Charset.pm IsStringUTF8ish function ?
>>
>>> +    utf8::decode($newxmlrecord);
> 
> Thanks for your feedback. I tried using C4::Charset.pm::IsStringUTF8ish
> function, but it doesn't solve the display issue with accented
> characters, when utf8::decode solves it.
> 
It might be that PERL utf8 flag is not set.
mmm It is really strange...
That function is only adding a test before doing the decode.
Having unconditionnal decode or encode is bound to raise an issue when
things are correctly done.
-- 
Henri-Damien LAURENT