[Koha-patches] Pull request - git://git.librarypolice.com/git/koha-galen.git 3.4_BibLibre-reports-tested

[Chris Cormack]

* LAURENT Henri-Damien (henridamien.laurent at biblibre.com) wrote:
> Hi,
> I didn't get that your message required a comment from us.
> I thought it was just for Release manager.

Have read through the answers below.
As there are no changes, Ill push the signed off branch today

Chris
> 
> Le 10/11/2010 05:11, Galen Charlton a écrit :
> > This is a tested version of BibLibre's 3.4/BibLibre-reports branch 
> > including some follow-up patches.  The following patches in BibLibre's
> > original pull request do  *not* have my sign-off and are consequently 
> > omitted from this branch:
> > 
> > * MT2268 : Followup Reports Guided columns.def
> > 
> > Patch resulted in double-encoding of diacritics in both
> > the column picker and report output.  Without the patch, diacritics
> > in report output and the column picker display correctly for me, so
> > whatever problem this patch was trying to solve ... works for me.
> Well it is ok... We removed that patch.
> And fixed the encoding in overdue_notices.
> 
> > 
> > * MT4038 : guided reports (Guided reports should be exported 
> >   according to the delimiter system preference)
> > 
> > I am in agreement with the general idea, but the implementation needs work:
> > 
> > [1] The patch does not check the value of the delimiter syspref correctly; in 
> > particular, if you set the syspref to 'tabs', the delimiter will be set to 
> > the literal string 'tabulation'.
> > [2] To be consistent with the non-guided reports, what it should be doing
> > is giving the user a choice of delimiters and using the syspref only to 
> > select the default choice.
> Good ideas. But no time to implement that.
> 
> > 
> > * bugfix on catalogue_stat : barcode & acquire fields
> > 
> > [1] This patch adds an extraneous file, reports/catalogue_stats.pl.orig
> rebasing is not that safe a process.
> 
> > [2] It also contains a regression for bug 4176.
> namely ? Is it because it is using a system preference ?
> The original patch was introduced long before the other one.
> Rejecting a patch because it doesnot foresee a to-be-declared bug (at
> the time the work was done) looks quite strange to me.
> 
> 
> > 
> > * (MT #4417) support dates for debarred's patrons stats
> > 
> > This patch assumes that borrowers.debarred is a date column; it is 
> > currently a Boolean.  If BibLibre is proposing to make that column a date,
> > this patch belongs on a separate topic branch implementing such a change.
> The change is done on BibLibre-Memb-circ-upd
> Maybe this should be done on this branch.
> This was done in this branch because it was a report modification.
> Maybe we should not have done Topic branches.
> 
> Friendly
> -- 
> Henri-Damien LAURENT
> BibLibre
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/

-- 
Chris Cormack
Catalyst IT Ltd.
+64 4 803 2238
PO Box 11-053, Manners St, Wellington 6142, New Zealand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: </pipermail/koha-patches/attachments/20101214/f040ed6e/attachment.pgp>