[Koha-patches] [PATCH 02/17] Fixes leading zeroes in Add Mulpiple Copies

paul.poulain at biblibre.com paul.poulain at biblibre.com
Thu Dec 16 15:11:08 CET 2010


From: Paul Poulain <paul.poulain at biblibre.com>

I don't know why, but removing sprintf solves the problems with leading zeroes
and the problems with large values.

(written by jean-andré santoni)
---
 C4/Barcodes.pm |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/C4/Barcodes.pm b/C4/Barcodes.pm
index 176d878..a528bd9 100644
--- a/C4/Barcodes.pm
+++ b/C4/Barcodes.pm
@@ -135,14 +135,11 @@ sub next_value ($;$) {
 		# Note, this enlargement might be undesireable for some barcode formats.
 		# Those should override next_value() to work accordingly.
 	$incr++;
-	my $width = $self->width || undef;
-	# we would want to use %$x.$xd, but that would break on large values, like 2160700004168
-	# so we let the object tell us if it has a width to focus on.  If not, we use float.
-	my $format = ($width ? '%'."$width.$width".'d' : '%.0f');
-	$debug and warn "sprintf(\"$format\",$incr)";
+
+	$debug and warn "$incr";
 	$head = $self->process_head($head,$max,$specific);
 	$tail = $self->process_tail($tail,$max,$specific);
-	my $next_value = $head . sprintf($format,$incr) . $tail;
+	my $next_value = $head . $incr . $tail;
 	$debug and print STDERR "(  next ) max barcode found: $next_value\n";
 	return $next_value;
 }
-- 
1.7.1



More information about the Koha-patches mailing list