[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5446 Fix a bug introduces by previous patch

Marcel de Rooy M.de.Rooy at rijksmuseum.nl
Fri Dec 17 12:16:52 CET 2010


From: Frédéric Demians <f.demians at tamil.fr>

When AcqCreateItem was set to 'cataloguing' there was no items fields in the
acq web form to validate in JS...

Alert commented.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
---
 .../prog/en/modules/acqui/neworderempty.tmpl       |   21 +++++++++++--------
 1 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl
index 85ccb6f..a76cb5c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl
@@ -40,16 +40,19 @@ function Check(ff) {
             _(") exceeds budget available (") + actTotal+")";
     }

-    var empty_item_mandatory = 0;
-    for (i = 0; i < ff.field_value.length; i++) {
-        if (ff.field_value[i].value.length == 0 && ff.mandatory[i].value == 1) {
-            empty_item_mandatory++;
+    if ( ff.field_value ) {
+        var empty_item_mandatory = 0;
+        for (i = 0; i < ff.field_value.length; i++) {
+            //alert("i = " + i + " => " + ff.kohafield[i] );
+            if (ff.field_value[i].value.length == 0 && ff.mandatory[i].value == 1) {
+                empty_item_mandatory++;
+            }
+        }
+        if (empty_item_mandatory > 0) {
+            ok = 1;
+            _alertString +=
+                "\n- " + empty_item_mandatory + _(" item mandatory fields empty");
         }
-    }
-    if (empty_item_mandatory > 0) {
-        ok = 1;
-        _alertString +=
-            "\n- " + empty_item_mandatory + _(" item mandatory fields empty");
     }

 if (ok) {
--
1.6.0.6


More information about the Koha-patches mailing list