[Koha-patches] [PATCH 2/3] fixed remaining calls to GetMember() that used old argument style

[Galen Charlton]

New way, correct way to use GetMember is

GetMember(field => fieldvalue[, field2 => field2value ...]);

e.g.,

GetMember(borrowernumber => $borrowernumber);

Signed-off-by: Galen Charlton <gmcharlt at gmail.com>
---
 C4/ILSDI/Services.pm     |    4 ++--
 acqui/addorderiso2709.pl |    2 +-
 acqui/basket.pl          |    2 +-
 acqui/booksellers.pl     |    2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
index ffd4792..bb32166 100644
--- a/C4/ILSDI/Services.pm
+++ b/C4/ILSDI/Services.pm
@@ -279,7 +279,7 @@ sub LookupPatron {
     my ($cgi) = @_;
 
     # Get the borrower...
-    my $borrower = GetMember( $cgi->param('id'), $cgi->param('id_type') );
+    my $borrower = GetMember($cgi->param('id_type') => $cgi->param('id'));
     if ( not $borrower->{'borrowernumber'} ) {
         return { message => 'PatronNotFound' };
     }
@@ -314,7 +314,7 @@ sub AuthenticatePatron {
     }
 
     # Get the borrower
-    my $borrower = GetMember( $cgi->param('username'), "userid" );
+    my $borrower = GetMember( userid => $cgi->param('username') );
 
     # Build the hashref
     my $patron->{'id'} = $borrower->{'borrowernumber'};
diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
index a028205..e9e9eeb 100755
--- a/acqui/addorderiso2709.pl
+++ b/acqui/addorderiso2709.pl
@@ -126,7 +126,7 @@ if ($op eq ""){
             if (C4::Context->preference("BiblioAddsAuthorities")){
                 my ($countlinked,$countcreated)=BiblioAddAuthorities($marcrecord, $cgiparams->{'frameworkcode'});
             }
-            my $patron = C4::Members->GetMember($loggedinuser);
+            my $patron = C4::Members->GetMember(borrowernumber => $loggedinuser);
             my $branch = C4::Branch->GetBranchDetail($patron->{branchcode});
             my ($invoice);
             my %orderinfo = ("biblionumber", $biblionumber,
diff --git a/acqui/basket.pl b/acqui/basket.pl
index 9687b88..a2f5b2e 100755
--- a/acqui/basket.pl
+++ b/acqui/basket.pl
@@ -192,7 +192,7 @@ if ( $op eq 'delete_confirm' ) {
     }
 #if the basket is closed,and the user has the permission to edit basketgroups, display a list of basketgroups
     my $basketgroups;
-    my $member = GetMember($loggedinuser, "borrowernumber");
+    my $member = GetMember(borrowernumber => $loggedinuser);
     if ($basket->{closedate} && haspermission({ flagsrequired   => { acquisition => 'group_manage'} })) {
         $basketgroups = GetBasketgroups($basket->{booksellerid});
         for (my $i=0; $i < scalar(@$basketgroups); $i++) {
diff --git a/acqui/booksellers.pl b/acqui/booksellers.pl
index 6dc48f6..7a3e326 100755
--- a/acqui/booksellers.pl
+++ b/acqui/booksellers.pl
@@ -112,7 +112,7 @@ for ( my $i = 0 ; $i < $count ; $i++ ) {
             $inner_line{basketname}     = $orders->[$i2]{'basketname'};
             $inner_line{total}        = scalar GetOrders($orders->[$i2]{'basketno'});
             $inner_line{authorisedby} = $orders->[$i2]{'authorisedby'};
-            my $authby = GetMember( $orders->[$i2]{'authorisedby'});
+            my $authby = GetMember(borrowernumber => $orders->[$i2]{'authorisedby'});
             $inner_line{surname}      = $authby->{'firstname'};
             $inner_line{firstname}    = $authby->{'surname'};
             $inner_line{creationdate} = format_date( $orders->[$i2]{'creationdate'} );
-- 
1.6.3.3