[Koha-patches] [PATCH] Bugfix: Make smart-rules.tmpl display zero values in fields.
Chris Nighswonger
cnighswonger at foundations.edu
Wed Feb 10 21:00:36 CET 2010
Since TMPL_IFs evaluate false if the template variable is 0,
smart-rules.tmpl was not displaying zero values in fields where
the db field value was indeed zero which leads to some small confusion.
This patch removes the TMPL_IFs since those fields will always be
populated with some value even if it is zero.
---
.../prog/en/modules/admin/smart-rules.tmpl | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl
index 709b9b4..5e5e183 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl
@@ -56,7 +56,7 @@ $(document).ready(function() {
<!-- /TMPL_LOOP -->
</select>
</form>
-<!-- TMPL_IF Name="definedbranch" --><form action="/cgi-bin/koha/admin/clone-rules.pl" method="post"><label for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidden" name="frombranch" value="<!-- TMPL_VAR NAME="branch" -->" />
+<!-- TMPL_IF Name="definedbranch" --><form action="/cgi-bin/koha/admin/clone-rules.pl" method="post"><label for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidden" name="frombranch" value="<!-- TMPL_VAR NAME="branch" -->" />
<select name="tobranch" id="tobranch"><!-- TMPL_LOOP NAME="branchloop" --><option value="<!-- TMPL_VAR NAME="value" -->"><!-- TMPL_VAR NAME="branchname" --></option><!-- /TMPL_LOOP --></select> <input type="submit" value="Clone" /></form><!-- /TMPL_IF --></fieldset>
<form method="post" action="/cgi-bin/koha/admin/smart-rules.pl">
@@ -100,14 +100,14 @@ $(document).ready(function() {
<!-- TMPL_VAR NAME="maxissueqty" -->
<!-- /TMPL_IF -->
</td>
- <td><!-- TMPL_IF NAME="issuelength" --><!-- TMPL_VAR NAME="issuelength" --> <!-- /TMPL_IF --></td>
+ <td><!-- TMPL_VAR NAME="issuelength" --></td>
<td><!-- TMPL_VAR NAME="fine" --></td>
- <td><!-- TMPL_IF NAME="chargeperiod" --><!-- TMPL_VAR NAME="chargeperiod" --> <!-- /TMPL_IF --></td>
- <td><!-- TMPL_IF NAME="firstremind" --><!-- TMPL_VAR NAME="firstremind" --> <!-- /TMPL_IF --></td>
- <td><!-- TMPL_IF NAME="finedays" --> <!-- TMPL_VAR NAME="finedays" --> <!-- /TMPL_IF --></td>
- <td><!-- TMPL_IF NAME="renewalsallowed" --><!-- TMPL_VAR NAME="renewalsallowed" --> <!-- /TMPL_IF --></td>
- <td><!-- TMPL_IF NAME="reservesallowed" --><!-- TMPL_VAR NAME="reservesallowed" --> <!-- /TMPL_IF --></td>
- <td><!-- TMPL_IF NAME="rentaldiscount" --><!-- TMPL_VAR NAME="rentaldiscount" --> <!-- /TMPL_IF --></td>
+ <td><!-- TMPL_VAR NAME="chargeperiod" --></td>
+ <td><!-- TMPL_VAR NAME="firstremind" --></td>
+ <td><!-- TMPL_VAR NAME="finedays" --></td>
+ <td><!-- TMPL_VAR NAME="renewalsallowed" --></td>
+ <td><!-- TMPL_VAR NAME="reservesallowed" --></td>
+ <td><!-- TMPL_VAR NAME="rentaldiscount" --></td>
<td>
<a class="button" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&itemtype=<!-- TMPL_VAR NAME="itemtype" -->&categorycode=<!-- TMPL_VAR NAME="categorycode" -->&branch=<!-- TMPL_VAR NAME="branch" -->">Delete</a>
</td>
@@ -198,7 +198,7 @@ $(document).ready(function() {
</div>
<!-- TMPL_IF NAME="show_branch_cat_rule_form" -->
<div class="help">
- <p>For this library, you can specify the maximum number of loans that
+ <p>For this library, you can specify the maximum number of loans that
a patron of a given category can make, regardless of the item type.
</p>
<p>If the total amount loanable for a given patron category is left blank,
--
1.6.0.4
More information about the Koha-patches
mailing list