[Koha-patches] [PATCH] [1/2] New Feature - restrict previously issued titles

[Michael Hafen]

Yeah, I think I fixed that in a later patch.  Must have forgotten to
send up the patch.

If you are interested in this feature I can pull the current code
together and resubmit.

On Thu, 2010-02-18 at 23:02 -0500, Galen Charlton wrote:
> Hi Michael,
> 
> On Thu, Oct 8, 2009 at 5:59 PM, Michael Hafen <mdhafen at tech.washk12.org> wrote:
> > +    #
> > +    # Check if borrower has checked this title out before
> > +    #
> > +    if ( C4::Context->preference("CircRestrictPreviouslyIssued") ) {
> > +        my $sth = $dbh->prepare("SELECT old_issues.itemnumber FROM old_issues CROSS JOIN items USING (itemnumber) WHERE biblionumber = ?");
> > +        $sth->execute($item->{'biblionumber'});
> > +        my $alreadyissued = $sth->fetchrow_hashref();
> > +        $sth->finish();
> > +        if ( $alreadyissued->{'itemnumber'} ) {
> > +            $needsconfirmation{PATRON_PREVIOUSLY_ISSUED} = 1;
> > +        }
> > +    }
> 
> The query would seem to trigger the warning if *any* patron had
> checked out the item, and I don't see why it should be a cross join
> instead of an inner join.  Shouldn't it also filter by the borrower?
> 
> Regards,
> 
> Galen


-- 
Michael Hafen
Systems Analyst and Programmer
Washington County School District
Utah, USA

for Koha checkout
http://development.washk12.org/gitweb/
or
git://development.washk12.org/koha