[Koha-patches] [PATCH] Bug 4016: Fixes holds listing wrong pick up location.

Galen Charlton gmcharlt at gmail.com
Mon Feb 22 00:10:58 CET 2010


Hi Garry,

As noted in the commentary on bug 4016, I've pushed this, but in the
form of a revert of the commit that introduced the bug rather than
your patch itself.

Regards,

Galen

On Sat, Feb 20, 2010 at 9:49 PM, Garry Collum <gcollum at gmail.com> wrote:
> Removed 'SearchMyLibraryFirst' from C4::Branch.pm and was going to add it to opac-search.pl, but it was already there. Removing it from Branch.pm had no affect on SearchMyLibraryFirst and fixed the pickup locations for holds.
> ---
>  C4/Branch.pm |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/C4/Branch.pm b/C4/Branch.pm
> index a6b1a3a..103a14d 100644
> --- a/C4/Branch.pm
> +++ b/C4/Branch.pm
> @@ -157,11 +157,10 @@ sub GetBranchesLoop (;$$) {  # since this is what most pages want anyway
>     my $onlymine = @_ ? shift : onlymine();
>     my $branches = GetBranches($onlymine);
>     my @loop;
> -    my $searchMyLibraryFirst = C4::Context->preference("SearchMyLibraryFirst");;
>     foreach (sort { $branches->{$a}->{branchname} cmp $branches->{$b}->{branchname} } keys %$branches) {
>         push @loop, {
>             value => $_,
> -            selected => (($_ eq $branch) && $searchMyLibraryFirst ) ? 1 : 0,
> +            selected => ($_ eq $branch) ? 1 : 0,
>             branchname => $branches->{$_}->{branchname},
>         };
>     }
> --
> 1.5.6.5
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Galen Charlton
gmcharlt at gmail.com



More information about the Koha-patches mailing list