[Koha-patches] [PATCH] [followup](bug #3897) fix variable name

[Ricardo Dias Marques]

Hi Nahuel (and Henri and Koha patches list),


On Fri, Dec 11, 2009, Nahuel ANGELINETTI
<nahuel.angelinetti at biblibre.com> wrote:

> this just change a bad variable name.
> ---
>  reserve/request.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/reserve/request.pl b/reserve/request.pl
> index 63b735d..8c55e54 100755
> --- a/reserve/request.pl
> +++ b/reserve/request.pl
> @@ -344,7 +344,7 @@ foreach my $biblioitemnumber (@biblioitemnumbers) {
>             }
>         }
>
> -        my $branch = C4::Circulation::_GetCircControlBranch($item, $borr);
> +        my $branch = C4::Circulation::_GetCircControlBranch($item, $borrowerinfo);
>
>   [snip]

It seems that this 11-Dec-2009 commit from Nahuel has NOT been applied
for Koha 3.0.5 (that was released on 17-Dec-2009). At least, as of
today (11-Jan-2010), I don't see it committed for the Koha 3.0.x
branch. The last commit for the "request.pl" file was also submitted
on 11-Dec-2009 (and was committed on 17-Dec-2009), but it still has
the wrong variable name ($borr instead of the correct $borrowerinfo):

http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=commit;h=230e51eb20fb1642319ec7508acd4322461a1c92

Because of this, in a Koha 3.0.5 installation, when I view a record
detail (in the "staff interface") - URL with "detail.pl" - if I click
on the "Holds" tab, on the left side, I get the following error
message:

----------------------------------------

http://myhost:8080/cgi-bin/koha/reserve/request.pl?biblionumber=1234

Koha error

The following fatal error has occurred:

Global symbol "$borr" requires explicit package name at
/koha/koha30xclone/reserve/request.pl line 347.
Execution of /koha/koha30xclone/reserve/request.pl aborted due to
compilation errors.
----------------------------------------


So, I'm asking the Koha 3.0.x Release Maintainer, the seemingly
tireless ( http://www.merriam-webster.com/thesaurus/tireless ) Henri
Damien-Laurent, to accept this patch from Nahuel, so it is included
for the next Koha 3.0.x version (3.0.6?)... please?  :)

Thanks in advance!

Cheers,
Ricardo Dias Marques
lists AT ricmarques DOT net