[Koha-patches] [PATCH] Custom Reports

[Kyle Hall]

> One thing I noticed though, there's no reference to KOHA_ROOT as you say
> in a later email.  Instead the path is hard coded here.

Indeed, I've already fixed that in my code, but I haven't sent a patch
for the new version. I'm waiting to see if anyone has more
suggestions.

Thanks,
Kyle

http://www.kylehall.info
Information Technology
Crawford County Federated Library System ( http://www.ccfls.org )




On Tue, Jan 26, 2010 at 12:08 PM, Michael Hafen
<mdhafen at tech.washk12.org> wrote:
> Looks like a cool feature.  I could use this to replace the custom
> reports I've made as well.  And it would be much easier to distribute
> them too.  We could have a wiki page, like the guided reports page, as a
> repository for community contributed custom reports.
>
> One thing I noticed though, there's no reference to KOHA_ROOT as you say
> in a later email.  Instead the path is hard coded here.
>
> On Tue, 2010-01-26 at 13:32 +0000, Kyle M Hall wrote:
>> diff --git a/C4/Reports/Custom.pm b/C4/Reports/Custom.pm
>> new file mode 100644
>> index 0000000..add811c
>> --- /dev/null
>> +++ b/C4/Reports/Custom.pm
> [snip]
>> +sub _GetReportsIniFiles {
>> +     my $reports_dir = '/home/koha/kohaclone/reports/custom_reports/';
>> +     opendir(DIRHANDLE, $reports_dir);
>> +     my @reports_dirs = readdir(DIRHANDLE);
>> +     closedir(DIRHANDLE);
>> +
> [snip]
>> diff --git a/reports/custom_reports_upload.pl b/reports/custom_reports_upload.pl
>> new file mode 100755
>> index 0000000..5bf98bf
>> --- /dev/null
>> +++ b/reports/custom_reports_upload.pl
> [snip]
>> +if ( ($op eq 'Upload') && $uploadfile ) {
>> +    my $custom_reports_dir = "/home/koha/kohaclone/reports/custom_reports/";
>> +
> [snip]
>
> Those are the two instances I noticed.
>
> --
> Michael Hafen
> Systems Analyst and Programmer
> Washington County School District
> Utah, USA
>
> for Koha checkout
> http://development.washk12.org/gitweb/
> or
> git://development.washk12.org/koha
>
>
>