[Koha-patches] [PATCH] Rotating Collections Fixes

Kyle Hall kyle.m.hall at gmail.com
Wed Jan 27 15:55:11 CET 2010


> Have you tested what would happen if an item in a rotating collection
> would fill a hold request?

It will print the message about belonging to a rotating collection at
another library, but should in no way interfere with filling a hold
request or any other action.

Kyle

http://www.kylehall.info
Information Technology
Crawford County Federated Library System ( http://www.ccfls.org )




On Wed, Jan 27, 2010 at 9:26 AM, Galen Charlton <gmcharlt at gmail.com> wrote:
> Hi,
>
> On Wed, Jan 27, 2010 at 9:06 AM, Kyle M Hall <kyle.m.hall at gmail.com> wrote:
>> This patch does the following:
>>  * Fixes the typos in updatedatabase.pl
>
> But nothing fixing the wrong with for colBranchcode - please fix and resubmit.
>
>> diff --git a/circ/returns.pl b/circ/returns.pl
>> index 1ed378b..da2b574 100755
>> --- a/circ/returns.pl
>> +++ b/circ/returns.pl
>> @@ -549,5 +549,16 @@ $template->param(
>>     overduecharges => $overduecharges,
>>  );
>>
>> +my $itemnumber = GetItemnumberFromBarcode( $query->param('barcode') );
>> +if ( $itemnumber ) {
>> +    my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber );
>> +    if ( ! ( $holdingBranch eq $collectionBranch ) ) {
>> +        $template->param(
>> +          collectionItemNeedsTransferred => 1,
>> +          collectionBranch => GetBranchName($collectionBranch),
>> +        );
>> +    }
>> +}
>> +
>
> Have you tested what would happen if an item in a rotating collection
> would fill a hold request?
>
> Regards,
>
> Galen
> --
> Galen Charlton
> gmcharlt at gmail.com
>



More information about the Koha-patches mailing list