[Koha-patches] [PATCH] Bug 4512 for master only (Encoding issue in downloaded data of guided reports) RESENT

Marcel de Rooy M.de.Rooy at rijksmuseum.nl
Wed Jun 9 14:34:08 CEST 2010


The line binmode STDOUT, ':utf8'; garbles the output. It was already utf8. The statement should be used on binary data, not on plain text. The statement occurred more frequently in older versions of the script; this last occurrence must be deleted too.
---
 reports/guided_reports.pl                          |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
index ad1ba6f..7c4fc9c 100755
--- a/reports/guided_reports.pl
+++ b/reports/guided_reports.pl
@@ -516,7 +516,7 @@ elsif ($phase eq 'Run this report'){
 }
 
 elsif ($phase eq 'Export'){
-    binmode STDOUT, ':utf8';
+    #binmode STDOUT, ':utf8'; #bug 4512
 
 	# export results to tab separated text or CSV
 	my $sql    = $input->param('sql');  # FIXME: use sql from saved report ID#, not new user-supplied SQL!
-- 
1.6.0.6



More information about the Koha-patches mailing list