[Koha-patches] FW: [PATCH] Bug 4514 (Error handling) -- For master only.

[Marcel de Rooy]

Sorry, 4489 should (of course) be 4514. 

-----Oorspronkelijk bericht-----
Van: Marcel de Rooy 
Verzonden: woensdag 9 juni 2010 16:23
Aan: 'Galen Charlton'; koha-patches at lists.koha-community.org
Onderwerp: RE: [Koha-patches] [PATCH] Bug 4514 (Error handling) -- For master only.

Should I update or add bug report? This patch was meant for master; then 5 pars are good.. 
Commit 9a3e95aa016dd1a5c09815b0ff5461c6f08c900e is already in 3.0.x for bug 4489.

Regards,
Marcel
-----Oorspronkelijk bericht-----
Van: Galen Charlton [mailto:gmcharlt at gmail.com] 
Verzonden: woensdag 9 juni 2010 16:09
Aan: Marcel de Rooy
CC: koha-patches at lists.koha-community.org
Onderwerp: Re: [Koha-patches] [PATCH] Bug 4514 (Error handling) -- For master only.

Hi,

On Mon, Jun 7, 2010 at 7:46 AM, Marcel de Rooy <M.de.Rooy at rijksmuseum.nl> wrote:
> -output_with_http_headers $query, $cookie, $template->output, 'html', '400 Bad Request';
> +output_html_with_http_headers $query, $cookie, $template->output, 'html', '400 Bad Request';

This would break things.  The parameters for
output_html_with_http_headers are $query, $cookie, $data, and HTTP
status; i.e., it supports up to four parameters, not five.  As far as
I can tell, bug 4514 applies to 3.0.x only; no patch for master is
currently indicated.

Regards,

Galen
-- 
Galen Charlton
gmcharlt at gmail.com