[Koha-patches] [3.2 06/13] [MT2766] Replaced CGI dropdown box call wich is deprecated

[Henri-Damien LAURENT]

From: Jean-André Santoni <jeanandre.santoni at biblibre.com>

---
 .../prog/en/modules/serials/claims.tmpl            |   21 ++++++++++++------
 serials/claims.pl                                  |   22 ++++++++++---------
 2 files changed, 26 insertions(+), 17 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tmpl
index 2f4fea1..ca74992 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tmpl
@@ -163,13 +163,20 @@
      <!-- /TMPL_IF -->
 <!-- TMPL_UNLESS NAME="letter" --><div class="dialog alert">No claims notice defined. <a href="/cgi-bin/koha/tools/letter.pl">Please define one</a>.</div><!-- /TMPL_UNLESS -->
     <form id="claims" name="claims" action="claims.pl" method="post">
-    <fieldset><label for="supplierid">View: </label>
-        <select id="supplierid" size="1" name="supplierid">
-        <!-- TMPL_LOOP name="supplier_loop" -->
-            <option value="<!--TMPL_VAR name="id"-->" <!-- TMPL_IF NAME="selected" -->selected="1"<!-- /TMPL_IF -->>
-                 <!--TMPL_VAR name="name"--></option>
-        <!--/TMPL_LOOP-->
-        </select>
+    <fieldset>
+	    <label for="supplierid">Supplier: </label>
+	    <select id="supplierid" name="supplierid">
+	        <!-- TMPL_LOOP name="suploop"-->
+	            <!-- TMPL_IF name="selected" -->
+	            <option value="<!-- TMPL_VAR name="id" -->" selected="selected" >
+	            <!-- TMPL_ELSE -->
+	            <option value="<!-- TMPL_VAR name="id" -->">
+	            <!-- /TMPL_IF -->
+	                <!-- TMPL_VAR name="name" -->
+	                (<!-- TMPL_VAR name="count" -->)
+	            </option>
+	        <!-- /TMPL_LOOP -->
+	    </select>
         <input type="submit" value="OK" />
         <!-- TMPL_IF name="phone" -->Phone: <!-- TMPL_VAR name="phone" --><!-- /TMPL_IF -->
         <!-- TMPL_IF name="booksellerfax" -->Fax: <!-- TMPL_VAR name="booksellerfax" --><!-- /TMPL_IF -->
diff --git a/serials/claims.pl b/serials/claims.pl
index 8ff672f..09999b4 100755
--- a/serials/claims.pl
+++ b/serials/claims.pl
@@ -29,17 +29,19 @@ my ($template, $loggedinuser, $cookie)
             flagsrequired => {serials => 1},
             debug => 1,
             });
-my $supplier_loop = [];
-foreach my $s_id (sort {$supplierlist{$a} cmp $supplierlist{$b} } keys %supplierlist){
-        my ($count) = GetLateOrMissingIssues($s_id,q{},$order);
-        push @{$supplier_loop}, {
-            id   => $s_id,
-            name => $supplierlist{$s_id} . "($count)",
-            selected => ( $supplierid && $supplierid == $s_id ),
-        };
+
+my @suploop;
+for ( sort {$supplierlist{$a} cmp $supplierlist{$b} } keys %supplierlist ) {
+    my ($count, @dummy) = GetLateOrMissingIssues($_, "", $order);
+    push @suploop, {
+        id       => $_,
+        name     => $supplierlist{$_},
+        count    => $count,
+        selected => $_ == $supplierid,
+    };
 }
 
-my $letters = GetLetters('claimissues');
+my $letters = GetLetters("claimissues");
 my @letters;
 foreach (keys %{$letters}){
     push @letters ,{code=>$_,name=> $letters->{$_}};
@@ -76,7 +78,7 @@ if ($op eq "send_alert"){
 $template->param('letters'=>\@letters,'letter'=>$letter);
 $template->param(
         order =>$order,
-        supplier_loop => $supplier_loop,
+        suploop => \@suploop,
         phone => $supplierinfo[0]->{phone},
         booksellerfax => $supplierinfo[0]->{booksellerfax},
         bookselleremail => $supplierinfo[0]->{bookselleremail},
-- 
1.6.3.3