[Koha-patches] [PATCH] Bug 3883: Fixes blank line in routing list.

Garry Collum gcollum at gmail.com
Sun May 2 01:37:06 CEST 2010


The blank line was being caused by the SELECT statement in the getroutinglist fuction of C4::Serials.  The LEFT join in the select statement was creating a single row result of NULL.  Changed the LEFT join to an INNER join.
---
 C4/Serials.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/C4/Serials.pm b/C4/Serials.pm
index 6cef7ef..bca9fc8 100644
--- a/C4/Serials.pm
+++ b/C4/Serials.pm
@@ -2008,7 +2008,7 @@ sub getroutinglist {
     my $sth              = $dbh->prepare(
         "SELECT routingid, borrowernumber, ranking, biblionumber 
             FROM subscription 
-            LEFT JOIN subscriptionroutinglist ON subscription.subscriptionid = subscriptionroutinglist.subscriptionid
+            JOIN subscriptionroutinglist ON subscription.subscriptionid = subscriptionroutinglist.subscriptionid
             WHERE subscription.subscriptionid = ? ORDER BY ranking ASC
                               "
     );
-- 
1.5.6.5




More information about the Koha-patches mailing list