[Koha-patches] [PATCH 12/12] Circulation Log Fixing :

[LAURENT Henri-Damien]

Le 01/05/2010 16:09, Galen Charlton a écrit :
> Hi,
> 
> On Fri, Apr 30, 2010 at 6:19 PM, Henri-Damien LAURENT
> <henridamien.laurent at biblibre.com> wrote:
>> For an issue, it was the biblionumber which was saved and not the itemnumber
>> This is quite not what we want to store
>> This patch fixes that.
> 
> I agree with you that in principle the action log ought to be
> recording the item ID for checkouts and returns, not just the bib ID,
> but I'm not pushing this patch as is:
> 
> * tools/viewlog.pl assumes that these types of log entries point to
> the bib record, not the item record; changing how this gets logged
> mid-stream would cause the patron modification log display to put to
> the wrong records
a simple change in templates could help for that.

> * it would break any reports that a library may be running on action_logs
When clicking on an issue log, getting the biblio back, instead of the
item checked out seems a serious mis information for me.

> 
> I think a better, longer-term fix would be to add additional columns
> to action_logs so that it can distinguish between different types of
> record ID more precisely.

We could also make the information become a JSON notation :
{"itemnumber": "1234","biblionumber":"5678","notes":"this is a note for
information"}
or even :
{"item":{"itemnumber": "1234","biblionumber":"5678"},"notes":"this is a
note for information"}
We could then adapt the HTML with jquery.

This would be meet a more general requirement and allow more flexibility
onwards.

My 2cts.
-- 
Henri-Damien LAURENT